-
Notifications
You must be signed in to change notification settings - Fork 20
feat: support community skins generation #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brtbrt
wants to merge
8
commits into
master
Choose a base branch
from
mbertamini/1588-import-community-skins
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7993284
feat(generate-design-tokens): support community skins generation
brtbrt 0b75aa7
docs(generate-design-tokens): document community skins generation
brtbrt 4d9e253
simplify release workflow into multi-step in place of multi-jobs
brtbrt f38c179
Merge branch 'master' into mbertamini/1588-import-community-skins
brtbrt 12ee574
convert the package to typescript
brtbrt e68aa1b
convert the package to typescript
brtbrt eb45316
convert the package to typescript
brtbrt 4b46137
convert the package to typescript
brtbrt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,28 @@ | ||
| # generate-design-tokens | ||
|
|
||
| Script to generate mistica skins (in src/skins folder) from design tokens imported from mistica-design repo. | ||
| Script to generate mistica skins from design tokens imported from the mistica-design repo. | ||
|
|
||
| Run: | ||
| ## Generated Files | ||
|
|
||
| - **Main skins** → `src/skins/` and `css/` | ||
| - **Community skins** → `src/community/skins/` and `css/community/` | ||
|
|
||
| The script discovers community skin tokens in the `tokens/community/` folder of the mistica-design repository | ||
| and generates corresponding TypeScript and CSS files. | ||
|
|
||
| ## Run | ||
|
|
||
| The script is written in TypeScript and runs directly on Node (>= 24), which strips the types at runtime, so | ||
| no build step is required: | ||
|
|
||
| ```bash | ||
| node index.ts | ||
| ``` | ||
|
|
||
| Type-check the package with: | ||
|
|
||
| ```bash | ||
| node index.js | ||
| yarn typecheck | ||
| ``` | ||
|
|
||
| This script is used by the import-design-tokens GitHub workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing the generation by using mistica-design
masterlocally