chore cover menu's checkbox selection behavior (non closing)#1586
Open
brtbrt wants to merge 3 commits into
Open
chore cover menu's checkbox selection behavior (non closing)#1586brtbrt wants to merge 3 commits into
brtbrt wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MenuItem checkbox behavior so selecting a checkbox option does not close the menu, and adds a regression test to lock that interaction in.
Changes:
- Keep the menu open when clicking a
MenuItemwithcontrolType="checkbox"by removing thecloseMenu()call from the checkboxonChangehandler. - Add a unit test verifying the menu remains open after clicking a checkbox menu item and that the handler is invoked.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/menu.tsx |
Stops closing the menu when interacting with checkbox menu items. |
src/__tests__/menu-test.tsx |
Adds test coverage to ensure checkbox menu items don’t close the menu on click. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Size stats
|
|
Deploy preview for mistica-web ready!
Deployed with vercel-action |
brtbrt
changed the title
|
Accessibility report ❌ 3 problems detectedcomponents-accordions--accordion-story [Movistar-new] (1 violations)components-accordions--accordion-story [O2-new] (1 violations)components-accordions--accordion-story [Blau] (1 violations)ℹ️ You can run this locally by executing |
brtbrt
force-pushed
the
master
branch
2 times, most recently
from
July 15, 2026 22:54
59b086a to
ac8e28d
Compare
Marcosld
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.