feat(Menu, IconButton): Use danger backgrounds with danger types#1505
Open
yceballost wants to merge 7 commits into
Open
feat(Menu, IconButton): Use danger backgrounds with danger types#1505yceballost wants to merge 7 commits into
yceballost wants to merge 7 commits into
Conversation
|
Size stats
|
|
Deploy preview for mistica-web ready!
Deployed with vercel-action |
|
Accessibility report ℹ️ You can run this locally by executing |
yceballost
marked this pull request as ready for review
February 24, 2026 18:31
aweell
reviewed
Feb 25, 2026
atabel
reviewed
Feb 27, 2026
atabel
previously approved these changes
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates danger/destructive UI feedback to use the dedicated danger background tokens, aligning MenuItem hover/press visuals with IconButton danger variants and the existing Button danger-link styles.
Changes:
- Add a dedicated destructive hover class for
MenuItemand apply it whendestructiveis true. - Introduce
menuItemHoveredDestructivestyles usingbuttonLinkDangerBackgroundPressed. - Update
IconButtondanger-transparent variants to use the corresponding danger background pressed tokens for hover/active.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/menu.tsx | Applies a new destructive-hover class when a menu item is destructive and focused/hovered. |
| src/menu.css.ts | Adds menuItemHoveredDestructive styling using danger pressed background tokens. |
| src/icon-button.css.ts | Switches danger-transparent hover/active backgrounds to danger pressed tokens (default/brand/negative). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '@media': { | ||
| [mq.touchableOnly]: { | ||
| backgroundColor: 'transparent', | ||
| transition: 'none', |
| }, | ||
| 'danger-transparent-negative': { | ||
| vars: { | ||
| [background]: skinVars.colors.buttonLinkDangerBackgroundBrand, |
brtbrt
force-pushed
the
master
branch
2 times, most recently
from
July 15, 2026 22:54
59b086a to
ac8e28d
Compare
|
Size stats
|
Marcosld
approved these changes
Jul 21, 2026
brtbrt
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example with danger/destructive components