feat(tokens): Include responsiveLayoutMargin tokens#2662
Merged
aweell merged 21 commits intoJul 21, 2026
Conversation
Addition of a new margin token for the responsive layout across all brands.
6 tasks
yceballost
changed the title
Marcosld
reviewed
Jun 29, 2026
Collaborator
|
You need to add in skin-schema.json the following:
That should fix the failing checks |
I removed the "margin" from the prefix, leaving only mobile, tablet, desktop, large desktop, and extra-large desktop.
…://github.com/Telefonica/mistica-design into 2648-responsive-layout-update-app-50-vivo-new
Add:
- "responsiveLayoutMargin"
- "responsiveLayoutMargin": { "$ref": "#/definitions/spacingProperties" }
- "largeDesktop": { "type": "number" } and "extraLargeDesktop": { "type": "number" }
Marcosld
approved these changes
Jul 1, 2026
Collaborator
|
Blocked by Telefonica/mistica-web#1611 |
yceballost
approved these changes
Jul 3, 2026
Closed
3 tasks
|
This PR should be updated: we're about to remove We're gonna have the following vivo ones:
|
brtbrt
self-requested a review
July 8, 2026 22:11
brtbrt
requested changes
Jul 8, 2026
brtbrt
left a comment
brtbrt
left a comment
There was a problem hiding this comment.
This PR should be updated: we're about to remove vivo-new, which, as of now, is vivo.
We're gonna have the following vivo ones:
- vivo (former vivo-new)
- vivo-evolution
Closed
3 tasks
Adjustment to the Vivo and Vivo New themes to reflect the Vivo and Vivo Evolution structure.
|
@annefranca in that case you can re-request review: I'll be notified to check the PR! :) |
brtbrt
reviewed
Jul 14, 2026
brtbrt
reviewed
Jul 14, 2026
brtbrt
reviewed
Jul 14, 2026
brtbrt
reviewed
Jul 14, 2026
brtbrt
requested changes
Jul 14, 2026
Collaborator
|
We've merged #2688, this has created som conflicts I'll solve so this PR is ready to go |
|
feel free to "resolve" comments I've left before the merge, and that now don't make sense :) |
brtbrt
approved these changes
Jul 16, 2026
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
brtbrt
approved these changes
Jul 17, 2026
brtbrt
reviewed
Jul 20, 2026
brtbrt
requested changes
Jul 20, 2026
brtbrt
left a comment
brtbrt
left a comment
There was a problem hiding this comment.
we need to redefine the jsom schema contract in order to require mobile as well as desktop
|
appreciated. thanks |
brtbrt
approved these changes
Jul 21, 2026
aweell
approved these changes
Jul 21, 2026
MurilloLeoni
pushed a commit
to MurilloLeoni/mistica-web
that referenced
this pull request
Jul 22, 2026
…1662) - `resopnsiveLayoutMargin` has been introduced - skins have been imported by Telefonica/mistica-design#2662 - package has been "improved" to let it run more easily by local command line # Todo - [x] `generate-design-tokens` from workflows, not locally, to check things are ok - [ ] update screenshots it diffs are ok with our changes --------- Co-authored-by: brtbrt <brtbrt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of a new margin token for the responsive layout across all brands.