Sort permissions ANDROID-17565#13
Merged
Merged
Conversation
jeprubio
commented
Mar 18, 2026
| appendElement("variant") { | ||
| setAttribute("name", variantName) | ||
| variantPermissions.forEach { permission -> | ||
| variantPermissions.sorted().forEach { permission -> |
jeprubio
requested review from
a team,
jeslat and
yamal-alm
and removed request for
a team
March 18, 2026 16:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply permission sorting and not only sort by variant.
Added a new test that checks the ordering which was failing with the current code and that now passes.
Also recreated the sample baseline and updated the permissions ordering in old tests.
The changes are only in the order when recreating the permissions, for checking the order keeps not being important.