Skip to content

Just swap recorded and golden line numbers in reports#10

Merged
nimeacuerdo merged 1 commit into
mainfrom
swap-lines-reporting
Sep 17, 2025
Merged

Just swap recorded and golden line numbers in reports#10
nimeacuerdo merged 1 commit into
mainfrom
swap-lines-reporting

Conversation

@nimeacuerdo

@nimeacuerdo nimeacuerdo commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

🥅 What's the goal?

Just swap recorded and golden line numbers in report to match their logs in the final report and avoid my (only me?) TOC with this, were golden logs are listed on the left and record on the right, whereas the message has the opposite order :)

Screenshot 2025-09-12 at 12 37 06

📘 Documentation changes?

  • No docs to update nor create

@nimeacuerdo
nimeacuerdo marked this pull request as ready for review September 12, 2025 10:43
@nimeacuerdo nimeacuerdo changed the title Just swap recorded and golden line numbers in report to match their l… Just swap recorded and golden line numbers in reports Sep 12, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR swaps the order of "recorded" and "golden" in error messages to match the visual layout in the final report where golden logs appear on the left and recorded logs appear on the right.

  • Updates error message format to display golden before recorded values
  • Ensures consistency between error message order and visual report layout
Comments suppressed due to low confidence (1)

loggerazzi/src/main/java/com/telefonica/loggerazzi/LogComparator.kt:18

  • For consistency with the updated size mismatch message format, this line should also swap the order to show golden before recorded: \"Different line at index $i: golden=${golden[i]}, recorded=${recorded[i]}\"
                compareResult.appendLine("Different line at index $i: recorded=${recorded[i]}, golden=${golden[i]}")

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dpastor dpastor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nimeacuerdo
nimeacuerdo merged commit ac56a44 into main Sep 17, 2025
1 check passed
@nimeacuerdo
nimeacuerdo deleted the swap-lines-reporting branch September 17, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants