Skip to content

Libls updated to v20 - #108

Merged
maximgorbatyuk merged 4 commits into
mainfrom
libs
Nov 24, 2025
Merged

maximgorbatyuk merged 4 commits into
mainfrom
libs

Conversation

@maximgorbatyuk

@maximgorbatyuk maximgorbatyuk commented Nov 24, 2025 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Upgraded Angular framework to version 20.x
    • Bumped project version to 1.0.0
    • Updated build tooling and compilation infrastructure to align with Angular 20.x
    • Upgraded TypeScript to version 5.9.3
    • Updated third-party library dependencies for compatibility with new framework version

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Nov 24, 2025 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Project upgraded from Angular 19.x to 20.x with corresponding dependency updates. Build tooling migrated from @angular-devkit/build-angular to @angular/build. Configuration files updated for compatibility. Return type signature and TypeScript override modifiers adjusted accordingly.

Changes

Cohort / File(s) Summary
Build System Migration
Dockerfile, angular.json, karma.conf.js
Updated Angular CLI version and migrated build targets from @angular-devkit/build-angular to @angular/build; removed Karma plugin entry for deprecated build-angular plugin; removed script dependency on marked.min.js
Configuration Updates
tsconfig.json
Changed moduleResolution from "node" to "bundler"; reformatted lib array; converted path mappings to single-element arrays
Dependency Upgrade
package.json
Bumped project version to 1.0.0; migrated Angular framework to 20.x; upgraded CLI, tooling, and related packages; removed @angular-devkit/build-angular; added marked dependency; upgraded TypeScript to ~5.9.3
Type Signature Updates
src/app/shared/services/session-storage-wrapper.service.ts
Updated getItem method return type from T to T | null
Test Utility Refinements
src/app/shared/test-utils/template-ref-stub.ts
Added override modifier to elementRef property and createEmbeddedView method

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–25 minutes

  • Angular 20.x compatibility impact across framework packages and build configuration
  • Build system migration completeness (verify all build targets properly configured with new @angular/build)
  • Dependency upgrade compatibility matrix (marked integration, third-party package versions)
  • Type signature change in SessionStorageWrapper (verify callers handle null return appropriately)

Poem

🐰 From nineteen to twenty, we hop and we bound,
New builders and bundlers, new ground we have found,
With marked paths unmarked and overrides blessed,
The TypeScript CLI now passes the test! 🎉

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch libs

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62d46c2 and 75e27a6.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (7)
  • Dockerfile (1 hunks)
  • angular.json (4 hunks)
  • karma.conf.js (1 hunks)
  • package.json (5 hunks)
  • src/app/shared/services/session-storage-wrapper.service.ts (1 hunks)
  • src/app/shared/test-utils/template-ref-stub.ts (1 hunks)
  • tsconfig.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@maximgorbatyuk
maximgorbatyuk merged commit 37be10c into main Nov 24, 2025
1 check passed
@maximgorbatyuk
maximgorbatyuk deleted the libs branch November 24, 2025 07:19
@coderabbitai coderabbitai Bot mentioned this pull request Dec 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant