Repository navigation
Remind the model to save a section it wrote as text - #69
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpt-oss can write a drafted section into its reply instead of calling
saveSection, so nothing is saved or checked.While
saveSectionis on offer, a reply that is recognisably a section (its first line is only a section title, or it is a save written as JSON, and it quotes at least two sources) goes back to the model with a reminder to save, up to two times. The visitor sees only the result. No reminder starts 25 seconds or more into the model call, to stay inside the route's 60 seconds. If the model never saves, the first reply passes as written.src/server/ai/cloudflare.ts: theremindingToSavemiddleware, next to the markup retrysrc/server/ai/unsaved-draft.ts: the ruleLocal:
npm run verifypasses, with new tests intests/unit/unsaved-draft.test.tsthat fail without the fix. Not run: end-to-end tests (no interface change), the real model.