Expand the community platform cards - #11
Conversation
SaharPak
left a comment
There was a problem hiding this comment.
Good refactor — the data-driven platforms[] array is a much cleaner pattern than the previous hardcoded cards. A few things to address before we merge.
Must Fix
-
Twittericon import (line 6) —Twitterwas deprecated/removed in recent lucide-react versions. This will break the build depending on the installed version. Replace with theXicon:import { X } from "lucide-react";
-
LinkedIn
href(line 46) — Links to a personal profile (linkedin.com/in/saharpak). Replace with the TechImmigrants community page:href: "https://linkedin.com/company/techimmigrants",
-
X/Twitter
href(line 55) — Links to a personal handle (x.com/saharlead). The Footer already uses the community account. Keep it consistent:href: "https://x.com/techimmigrants",
Should Fix
-
Telegram channel icon —
Radio(line 20) —Radiodoesn't visually convey "Telegram". Consider usingSend(paper-plane) which is the recognized Telegram symbol, and keepMessageCirclefor the group. -
LinkedIn & X/Twitter stats — "Follow" is a CTA, not a stat. Show the actual follower counts:
// LinkedIn stat: "+۹۰۰۰ فالوور", // X/Twitter stat: "+۱۰۰۰۰ فالوور",
-
YouTube stat (line 36) — Show subscriber count instead of episode count:
stat: "+۱۰۰۰۰ سابسکرایبر",
-
GitHub stat (line 63) —
"۱۰ مخزن، مشارکت کنید"mixes a count with a CTA. Keep it clean — just"۱۰ مخزن". Move "مشارکت کنید" to the description if needed. -
Stat icon in render template (line 113) — The
Usersicon is used for every card's stat row, but it doesn't fit YouTube (subscribers) or GitHub (repos). Consider a per-platform stat icon or a generic one likeTrendingUp.
Nit
- Hardcoded stats — All stats are static strings that will go stale as the community grows. Add a comment at the top of the
platformsarray noting these need periodic manual updates, so future contributors know.
- Replace deprecated Twitter icon with X - Fix LinkedIn and X/Twitter hrefs to point to community pages - Use Send icon for Telegram channel instead of Radio - Show actual follower/subscriber counts instead of CTAs - Clean up GitHub stat to just the repo count - Use TrendingUp as a universal stat icon - Add note about hardcoded stats needing periodic updates
|
Thanks for the solid refactor @adminlip — the data-driven I went ahead and pushed a commit to your branch addressing the review items:
Build passes. Let me know if you have any questions about the changes. |
lucide-react's X icon is a close/cross glyph, not the X (Twitter) brand mark, so the card rendered like a dismiss button. Swap in an inline SVG of the official X logo that matches the icon component API.
Extract the inline X logo into a reusable XIcon component and use it in the footer in place of the deprecated lucide Twitter bird, also pointing the footer link at the X community account for consistency.
This updates the community section to show all six Tech Immigrants platforms in a responsive card grid, including the Telegram channel and group, YouTube, LinkedIn, X/Twitter, and GitHub with the current stats and external links. I verified the production build with
npm run build, checked the diff withgit diff --check, and confirmed the expected platform links and displayed counts are present.