Skip to content

Linting retro rewind code - #183

Merged
DirkDoes merged 2 commits into
devfrom
linting-retro-rewind-code
Jul 1, 2025
Merged

Linting retro rewind code#183
DirkDoes merged 2 commits into
devfrom
linting-retro-rewind-code

Conversation

@DirkDoes

@DirkDoes DirkDoes commented Jul 1, 2025

Copy link
Copy Markdown
Member

change the RetroRewind installation a bit

How to Test:

Install RR and test if it installs it all correctly/

What Has Been Changed:

  1. Removed the double path concatination (just picked the first one and went with that)
  2. Removed the fallback sourceFolder path!!
    Initially it would search for folder RetroRewind6, and if extraction folder was there, but not RetroRewind6 then it would just pick the first one in that list O_O. It should not do that and just throw. the zip must always contain this folder, if it doesn't, then the downloaded zip might be corrupted, or who knows... . In any case, there are also more folders, and the zip also contains the folder named apps which means that the first folder is not even RetroRewind6. And even if it was, ZPL could have added this apps folder later without us knowing and then it would also break. So yea, removed that bit.
  3. Added logging for this installation. Just 1 log for now in this downloadExtract method. might add it in the rest of the file later.

Related Issue Link: #181

@DirkDoes
DirkDoes requested a review from patchzyy July 1, 2025 14:51
@DirkDoes
DirkDoes merged commit 0f3d7ff into dev Jul 1, 2025
1 check passed
@DirkDoes
DirkDoes deleted the linting-retro-rewind-code branch July 1, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant