Linting retro rewind code - #183
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change the RetroRewind installation a bit
How to Test:
Install RR and test if it installs it all correctly/
What Has Been Changed:
Initially it would search for folder
RetroRewind6, and if extraction folder was there, but notRetroRewind6then it would just pick the first one in that list O_O. It should not do that and just throw. the zip must always contain this folder, if it doesn't, then the downloaded zip might be corrupted, or who knows... . In any case, there are also more folders, and the zip also contains the folder namedappswhich means that the first folder is not evenRetroRewind6. And even if it was, ZPL could have added thisappsfolder later without us knowing and then it would also break. So yea, removed that bit.Related Issue Link: #181