fix: installing across volumes doesnt work - #182
Merged
Conversation
change from Directory.Move to File.Move
Collaborator
|
I would suggest the following one-line change to fix the permission issue of WheelWizard/WheelWizard/Features/CustomDistributions/RetroRewind.cs Lines 353 to 367 in b95f437 + entry.ExternalAttributes |= Convert.ToInt32("644", 8) << 16;
// Extract the file
entry.ExtractToFile(destinationPath, overwrite: true);
} I've tested this patch and it seems to work just fine now. |
Contributor
Author
|
Updated the PR to include your solution @matellush |
DirkDoes
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
change the RetroRewind installation from using
Directory.MovetoFile.Moveto address the issue mentioned belowHow to Test:
make sure WheelWizard and the Dolphin User folder are on different drives, then try installing RetroRewind.
What Has Been Changed:
I removed the Directory.Move call and instead copy over each file individually.
I also moved the cleanup of previous installations into the RemoveAsync() function.
Related Issue Link:
#181
Checklist before merging