Skip to content

fix: installing across volumes doesnt work - #182

Merged
DirkDoes merged 2 commits into
TeamWheelWizard:devfrom
Umbrason:fixRRInstall
Jul 1, 2025
Merged

fix: installing across volumes doesnt work#182
DirkDoes merged 2 commits into
TeamWheelWizard:devfrom
Umbrason:fixRRInstall

Conversation

@Umbrason

Copy link
Copy Markdown
Contributor

Purpose of this PR:

change the RetroRewind installation from using Directory.Move to File.Move to address the issue mentioned below

How to Test:

make sure WheelWizard and the Dolphin User folder are on different drives, then try installing RetroRewind.

What Has Been Changed:

I removed the Directory.Move call and instead copy over each file individually.
I also moved the cleanup of previous installations into the RemoveAsync() function.

Related Issue Link:

#181

Checklist before merging

  • You have created relevant tests

change from Directory.Move to File.Move
@matellush

Copy link
Copy Markdown
Collaborator

I would suggest the following one-line change to fix the permission issue of 28.szs having ------x---:

// If it’s a directory, create it
if (entry.FullName.EndsWith(Path.AltDirectorySeparatorChar))
{
_fileSystem.Directory.CreateDirectory(destinationPath);
}
else
{
// Ensure folder exists
var dir = _fileSystem.Path.GetDirectoryName(destinationPath);
if (!string.IsNullOrEmpty(dir))
_fileSystem.Directory.CreateDirectory(dir);
// Extract the file
entry.ExtractToFile(destinationPath, overwrite: true);
}

+    entry.ExternalAttributes |= Convert.ToInt32("644", 8) << 16;
     // Extract the file 
     entry.ExtractToFile(destinationPath, overwrite: true); 
 } 

I've tested this patch and it seems to work just fine now.

@Umbrason

Umbrason commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Updated the PR to include your solution @matellush

@DirkDoes
DirkDoes merged commit 59f9bc6 into TeamWheelWizard:dev Jul 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants