Courses user profile#171
Open
Martin092 wants to merge 7 commits into
Open
Conversation
Collaborator
|
Nice work overall. One blocker: on /publish/course, the form is passed close={() => {}}, so the Cancel button does nothing. Could you wire it to return to /publish or the intended previous page? The PR is also currently conflicting with main, so please rebase it |
Collaborator
|
The card-width change itself looks good, but this has more revert commits that would add email verified and password which we dont want and it has to be rebased carefully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Additional info: I extracted the code from the modal for course creation into a separate component (and left the modal as a wrapper), so that I can reuse the course creation code as its own page. There were a bunch of problems with that, so whoever is reviewing might want to pay extra attention to that part in case I missed something.