Fix #531: Allow empty graphs in check_well_formed#537
Open
ECZ-Quantum-Labs wants to merge 13 commits into
Open
Fix #531: Allow empty graphs in check_well_formed#537ECZ-Quantum-Labs wants to merge 13 commits into
ECZ-Quantum-Labs wants to merge 13 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
==========================================
- Coverage 88.85% 88.84% -0.01%
==========================================
Files 49 49
Lines 7135 7139 +4
==========================================
+ Hits 6340 6343 +3
- Misses 795 796 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting, please check the following:
nox)ruffCONTRIBUTING.mdfor more detailsThen, please fill in below:
Context (if applicable): Fixes issue #531 where empty graphs were incorrectly rejected by check_well_formed()
Description of the change: - Added early return for empty graphs in _check_flow_general_properties
_check_flow_general_propertiesrejects empty graphs #531 now passesRelated issue: