fix(visualization): keep layer arrow in frame for linear flows#536
Open
shantoshdurai wants to merge 1 commit into
Open
fix(visualization): keep layer arrow in frame for linear flows#536shantoshdurai wants to merge 1 commit into
shantoshdurai wants to merge 1 commit into
Conversation
Set preliminary plot limits before drawing layer annotations so point-based offsets map correctly when all nodes share one y row. Expand ymin for layer label height and enforce a minimum vertical axis span for degenerate layouts. Fixes TeamGraphix#535
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 88.85% 88.83% -0.03%
==========================================
Files 49 49
Lines 7135 7146 +11
==========================================
+ Hits 6340 6348 +8
- Misses 795 798 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #535
Linear open graphs place every node on one row, so
ymin == ymax. Layer labels use fixed point offsets belowplot_lims.ymin, but the ymin adjustment in_draw_layersran before axis limits were set, so the data/display transform was degenerate and the "Layer" arrow ended up below the plot frame.Changes
_draw_layersso point-based offsets map correctlyyminto include layer label height (va='top') plus padding_set_plot_limswhen node rows collapse to one linetest_linear_causal_flow_layer_label_in_frameVerify