Add amplitude damping noise model#529
Open
automatedsoftwaresystemsllc-eng wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 49 50 +1
Lines 7135 7207 +72
=======================================
+ Hits 6340 6404 +64
- Misses 795 803 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pranav97nair
requested changes
Jun 8, 2026
pranav97nair
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
After taking a look through the code, we would like to ask you to please implement the following changes:
- Add tests for verifying the action of amplitude damping noise at the entanglement and measurement steps of the Hadamard pattern . In both cases, we would like to check the simulated output density matrix against the expected analytical one as a function of a randomized error probability.
- For any tests in
test_noise_model.pyandtest_noisy_density_matrix.pythat should behave identically regardless of noise model, parametrize them to run for bothDepolarisingNoiseModelandAmplitudeDampingNoiseModel. For example, tests that check the action of theconfuse_result()method.
Feel free to let us know any comments or questions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
uff check graphix\channels.py graphix\noise_models\amplitude_damping.py graphix\noise_models\init.py graphix\init.py tests\test_kraus.py tests\test_noise_model.py tests\test_noisy_density_matrix.py passed locally.
uff format --check graphix\channels.py graphix\noise_models\amplitude_damping.py graphix\noise_models\init.py graphix\init.py tests\test_kraus.py tests\test_noise_model.py tests\test_noisy_density_matrix.py passed locally.
Assisted by OpenAI Codex.