Skip to content

fix: apply configured audio volumes - #847

Merged
Mivik merged 4 commits into
TeamFlos:mainfrom
Pimeng:fix/audio-unadjustable
Jul 30, 2026
Merged

fix: apply configured audio volumes#847
Mivik merged 4 commits into
TeamFlos:mainfrom
Pimeng:fix/audio-unadjustable

Conversation

@Pimeng

@Pimeng Pimeng commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

修复 主界面点击音效、谱面预览时 音量不可调节的问题

@Pimeng

Pimeng commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

ping #807

Comment thread phira/src/scene/song.rs Outdated
clip,
MusicParams {
amplifier: 0.7,
amplifier: get_data().config.volume_music,

@Pimeng Pimeng Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没绷住,谱面预览音量调不了是因为这里写死了 0.7

@YuevUwU YuevUwU Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只是猜测,Mivik的原始意图也可能是Music Volume的0.7倍
#199 也发现了比较小声这件事
0.7可能从prpr的cali音量而来(硬编码,非倍数,那时候已经有这个音量config了)
迁移到了phira的cali.ogg直接套用sasa的默认值1.0了
phira的0.7已经只剩下关于song preview本地create_music函数的两处使用了
既然cali那边phira也改了,就不知道开发者还保不保留这个特性了

This comment was marked as off-topic.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里还是用使用 volume_music*0.7 比较好

@Pimeng Pimeng Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@YuevUwU

YuevUwU commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

fix #267
fix #807
Note: This doesn't work. Required PR author or anyone with push access to TeamFlos/phira to link to these issue to close those issue after this PR is merged. [doc-link] [doc-allow-edit]

@YuevUwU

YuevUwU commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Feedback: consider Applying SFX volume to Respack page

let _ = sfxs[(irnd % 3) as usize].play(PlaySfxParams::default());

@Pimeng

Pimeng commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Feedback: consider Applying SFX volume to Respack page

let _ = sfxs[(irnd % 3) as usize].play(PlaySfxParams::default());

Copy, will take that on my wake time

@Pimeng

This comment was marked as resolved.

@Pimeng Pimeng linked an issue Jul 21, 2026 that may be closed by this pull request
@Pimeng

Pimeng commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

测试没什么问题,材质包和延迟调节都能吃到这里的设置
回归没跑过,不过应该也差不多

@Mivik
Mivik merged commit fbbb54e into TeamFlos:main Jul 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Phira Spectrum Preview Adjustment and UI click sound effect cannot be adjusted 延迟校准页面打击音 随音效音量关闭而关闭

3 participants