Presentation mode - #13
Open
JacksonMcLaughlin wants to merge 7 commits into
Open
Conversation
Contributor
Author
|
still doesn't actually use the presentation mode pref, so need to redeploy to go back to normal |
octylFractal
requested changes
May 9, 2018
octylFractal
left a comment
octylFractal
left a comment
Member
There was a problem hiding this comment.
some stuff for code quality
| private final Arm arm = Robot.runningRobot.arm; | ||
| private final Clamp clamp = Robot.runningRobot.clamp; | ||
| private final Floppies floppies = Robot.runningRobot.floppies; | ||
| private final boolean open = clamp.isOpen(); |
Member
There was a problem hiding this comment.
isn't this the state at the start of the robot? why do you set it to this and not some specific state?
|
|
||
| public static final int AUTO_PUNCH_BUTTON = 2; | ||
|
|
||
| public static final int DEAD_MAN_BUTTON = 1; |
Member
There was a problem hiding this comment.
is this tabbed? please remove
|
|
||
| public class PresentationMode { | ||
|
|
||
| public static boolean inPresentationMode() { |
| //autoCollectButton.whenPressed(new CollectGrabRaise(true)); | ||
|
|
||
| // remove climb for adams school | ||
| /* |
Member
There was a problem hiding this comment.
why isn't this just in an if(PresentationMode.inPresentationMode)? that's why i made it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.