Skip to content

feat: ai, slack test 코드 작성#113

Merged
hyeeuncho merged 3 commits into
developfrom
feature/ai-test
May 29, 2026
Merged

feat: ai, slack test 코드 작성#113
hyeeuncho merged 3 commits into
developfrom
feature/ai-test

Conversation

@hyeeuncho

Copy link
Copy Markdown
Contributor

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해 주세요. (마이크로서비스 명시)

  • [ai-service] test 코드 작성
  • [slack-service] test 코드 작성

@hyeeuncho hyeeuncho self-assigned this May 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive unit tests for AiMessageService, AiService, SlackMessageService, and SlackService to verify core business logic, status transitions, and role-based access control. The review feedback focuses on improving code maintainability and readability by replacing hardcoded "MASTER" role strings with the UserRole enum, adding the necessary imports, and using static imports for Mockito's ArgumentMatchers instead of fully qualified names.

Comment thread ai-service/src/test/java/com/msa/ai_service/service/AiMessageServiceTest.java Outdated
Comment thread slack-service/src/test/java/com/msa/slack_service/service/SlackServiceTest.java Outdated
Comment thread slack-service/src/test/java/com/msa/slack_service/service/SlackServiceTest.java Outdated
Comment thread slack-service/src/test/java/com/msa/slack_service/service/SlackServiceTest.java Outdated
Comment thread slack-service/src/test/java/com/msa/slack_service/service/SlackServiceTest.java Outdated
@hyeeuncho hyeeuncho marked this pull request as ready for review May 29, 2026 05:28
@hyeeuncho hyeeuncho merged commit 024aba1 into develop May 29, 2026
4 checks passed
@hyeeuncho hyeeuncho deleted the feature/ai-test branch May 29, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants