new Constants int implementation - #128
Open
Mason-Lam wants to merge 37 commits into
Open
Conversation
Changed the class so you don't have to retype every constant into the class, (if anyone can figure out how to stop constant folding of final variables(in a good way because there is a method but I don't like it), that would be great).
Rewriting the ConstantsInt class
just update constants directly
Edit Constants class directly
Fix Constant Folding so you can just change constants.
changes based on Sohan's feedback
Added it so narwhaldashboard isn't flooded with Constants.
Only NarwhalDashboard can edit constants.
Constantsint suggestions
Throws the correct exception so you actually know what's wrong.
FieryXY
approved these changes
Jun 28, 2022
Check if field is final before trying to modify it.
Take a sledgehammer and make every method synchronized because I do not feel like learning how multi-threading works so make everything thread safe. A perfect solution. 50% chance this gets reverted. Although the next solution is just make every variable volatile and I don't know where I'm going with this description.
NarhwalDashboard is now the only class that can access ConstantsInt in a meaningful way(HOPEFULLY).
mika-okamoto
added
the
git fixes required
Replaced all instances of JoystickButton with Trigger.
POVButtons not changed to triggers yet, will do in another pull request
Co-Authored-By: Teja Yaramada <74982797+teja-yaramada@users.noreply.github.com> Co-Authored-By: Mason-Lam <97353903+Mason-Lam@users.noreply.github.com>
Co-Authored-By: Arav Chadha <97276472+AravCGitHub@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows NarwhalDashboard to change any existing constant(that's a boolean, or Number).