Overhaul of States - #2
Open
Garrison-Price wants to merge 2 commits into
Open
Conversation
Mason-Lam
reviewed
Oct 29, 2024
| return instance.kicker.hasObjectPresent(); | ||
| } | ||
|
|
||
| public static boolean kickerNoObjectPresent() { |
There was a problem hiding this comment.
The static methods kind of ruin the point of the Singleton pattern.
Mason-Lam
reviewed
Oct 29, 2024
| } | ||
|
|
||
| public Command setState(HopperState state) { | ||
| currentState = state; |
There was a problem hiding this comment.
This does not work because it only sets the state the first time the method is called, not every time the command is run. This is also probably the reason the isState function doesn't work because == works for enum values.
Mason-Lam
reviewed
Oct 29, 2024
Mason-Lam
left a comment
Mason-Lam
left a comment
There was a problem hiding this comment.
Bug in the hopper changes, more in depth on comments left on file.
lucasjhan08
added a commit
that referenced
this pull request
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.