Refactoring to Clean Things Up - #1
Open
Garrison-Price wants to merge 12 commits into
Open
Conversation
…w call in other code areas.
They are set to coast in disabled init, but we forgot to set them back to brake
Mason-Lam
reviewed
Oct 29, 2024
|
|
||
| @Override | ||
| public void autonomousInit() { | ||
| updateAllianceFromDS(); |
There was a problem hiding this comment.
I don't think this works because the auto paths are already loaded in RobotInit by the time this is called. You could reload the auto paths if the alliance is changed.
There was a problem hiding this comment.
Nvm it flips the path when the command is called.
lucasjhan08
added a commit
that referenced
this pull request
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spending some time cleaning things up. I'll try to keep this branch up to date with changes on the robot_state_dev branch. Will eventually add comments to this PR to explain why certain things have changed.
DON'T MERGE THIS, YET