Consolidate native qualification and harden evidence publication - #84
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 92 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
Addressed the 17 release-code findings in e65416a, with regression tests. The full per-comment disposition is in docs/pr-84-review-disposition.md. Local verification: 651 Python 3.13 tests passed, one skipped, 82.38% coverage; focused Python 3.10 tests passed; formatting, lint, type/security checks, pinned Rust 1.88 and Go 1.23.5 checks, package privacy, and sdist/wheel agreement passed. Four 5,000-event native qualifications retained their exact IDs. The Go FOK negative result and Nautilus positive/negative campaigns also retained their expected identities and reduced trace. One earlier full Python run hit an existing two-second subprocess startup timeout during concurrent builds; the isolated test and subsequent full confirmation runs passed without changing that timeout. The 13 historical/frozen research findings remain open for a separate research disposition. No experiment runner, frozen input, retained evaluator artifact, or recorded qualification fixture was changed. No completed provider turn was retried. Passing release checks is not a reason to dismiss those research comments or bypass the merge gate. This update does not merge the PR, publish a release, resend the maintainer invitation, or change its immutable source/wheel references. Remote checks must be assessed on the new SHA. |
There was a problem hiding this comment.
All reported issues were addressed across 28 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Summary
Consolidates the verified qualification work and follow-up hardening on current
main.intrepidkarthi/orderbookadapter, scoped FIFO qualification, and retained unfillable-FOK contract difference (not an upstream bug claim).55e3c4bsnapshot; sending it is not evidence of independent adoption.Local validation
Remote/release gate
Remote CI must pass on this PR, including the four supported Python minors and all affected native integrations. No package upload or public release is requested by this PR. The current public release remains 0.6.0; the new source features will be prepared as a distinct next version after these checks.
Summary by cubic
Consolidates two new native qualification surfaces and evidence hardening onto
main, addressing the release-code findings from the PR #84 automated review.New qualification
intrepidkarthi/orderbookv0.26.0 with FIFO/pro-rata qualification and an explicit unfillable-FOK contract difference, not an upstream bug claim.l3-book-replay-v1surface for L3 order-book mirrors that do not cross submitted orders, with a pinned NautilusTrader adapter and deterministic campaigns.experiments/private/and defers the frozen research findings to issue 85.Hardening
SOURCES.txtinventories.Written for commit 4ba428e. Summary will update on new commits.