Require clean shutdown before protocol completion - #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Observable change
Only the previously dishonest close-failure path changes: complete is omitted and ADAPTER_ERROR is emitted. Normal and protocol-error transcripts remain byte-for-byte identical.
Verification
Summary by cubic
Enforces a clean shutdown contract for the stdio protocol:
completeis sent only after a successfuladapter.close(). If shutdown fails, the server sends a singleADAPTER_ERROR, omitscomplete, and exits with code2, while preserving any earlierPROTOCOL_ERROR.complete; onclose()failure, emitADAPTER_ERRORand exit2.PROTOCOL_ERRORifclose()also fails; don’t overwrite the terminal error._write_errorand update docs/tests; normal and protocol-error transcripts remain unchanged.Written for commit 927a330. Summary will update on new commits.