Skip to content

Centralize operational divergence classification - #73

Merged
Taz33m merged 1 commit into
mainfrom
codex/operational-failure-classifier
Aug 5, 2026
Merged

Centralize operational divergence classification#73
Taz33m merged 1 commit into
mainfrom
codex/operational-failure-classifier

Conversation

@Taz33m

@Taz33m Taz33m commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • define operational divergence once in the classification layer
  • reuse it for in-memory reports and serialized artifact exit codes
  • remove the classification module's runtime dependency on compare
  • preserve every existing category/snapshot/close classification

Verification

  • full pytest suite
  • black, flake8, mypy, bandit, compileall
  • exhaustive 297-case baseline comparison is byte-for-byte identical

Summary by cubic

Centralized operational divergence classification in classification.is_operational_divergence, and reused it for ConformanceReport.operational_failure and artifact exit codes. No behavior change; this removes classification’s runtime dependency on compare and keeps exit codes consistent.

  • Refactors
    • Added is_operational_divergence(category, snapshot_failed, close_failed) in classification.
    • Used it in compare.ConformanceReport.operational_failure and exit_codes._divergence_exit_code.
    • Switched classificationcompare import to type-only to avoid runtime coupling.
    • Kept all classifications unchanged; baseline remains identical and tests assert operational_failure.

Written for commit c874f4e. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@Taz33m
Taz33m merged commit 3e48f8a into main Aug 5, 2026
8 checks passed
@Taz33m
Taz33m deleted the codex/operational-failure-classifier branch August 5, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant