skills: required-reading gates; remove the ai-docs command and skill#20
Open
Tanq16 wants to merge 2 commits into
Open
skills: required-reading gates; remove the ai-docs command and skill#20Tanq16 wants to merge 2 commits into
Tanq16 wants to merge 2 commits into
Conversation
Every skill that carries reference files now opens with a "Start here — required reading" gate, tiered into Always (rule-defining refs, read in full before acting) and When-<trigger> (heavy templates, read on demand or by a delegated subagent). This makes reading the relevant references the first instruction the model sees, instead of an optional table at the foot of the file. A new repo-root test (skills_gate_test.go) keeps the gates honest across both shipped roots — the embedded global plugin and the claudex-dev plugin: it asserts the gate exists when a skill has references, that every references/*.md is named inside the gate block, and that no cited ./references or ../sibling/references path is dead. Skills with no reference files (cross-ai, develop) are exempt but still link-checked.
Strips the AI-docs feature end to end: the `claudex ai-docs` subcommand (cmd/ai-docs.go + its root registration), the embedded ai-docs skill and its Node viewer assets under internal/embedded/default-skills/ai-docs, the develop Skill Map row that pointed at it, and every README mention (the capabilities row, the global-plugin bullet, and the `ai-docs` command section). The global plugin now ships only the cross-ai skill plus the ClaudeX output style and .lsp.json. History retains the feature if it is ever wanted back. The plugins_test synthetic fixture named "ai-docs" is renamed to "nested-skill" so no deleted skill is referenced in tests.
Tanq16
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related changes to the shipped skills.
1. Required-reading gates for every skill's references
Every skill that ships reference files now opens — right after When to Use — with a
## Start here — required readinggate, tiered as:html-template.md,highway-template.md,command-templates.md, …), each tagged with the sub-task that requires it; a subagent may read it on delegation.This moves the enforcement point from an optional
## Referencestable at the foot of each file to a mandatory, tiered gate at the top.review-codeanddevelopget orchestrator variants (their "references" are the domain files / other skills they route to); skills with no reference files are exempt.Enforcement: new repo-root
skills_gate_test.gowalks both shipped roots —internal/embedded/default-skills/andskills/— and asserts a gate exists whenever a skill has reference files, everyreferences/*.mdis named inside the gate block, and no cited./references/…or../sibling/references/…path is dead. Verified the guard bites (planted an orphan ref and a dead link — each failed the exact skill; reverted, green).2. Remove the ai-docs feature entirely
The AI-docs command/skill/viewer wasn't pulling its weight, so it's stripped end to end:
claudex ai-docssubcommand (cmd/ai-docs.go+ itsroot.goregistration)ai-docsskill and its Node viewer assets (internal/embedded/default-skills/ai-docs/)developSkill Map row pointing at itai-docscommand section)The global plugin now ships the
cross-aiskill plus the ClaudeX output style and.lsp.json. History keeps the feature if it's ever wanted back. A synthetic test fixture that happened to be namedai-docswas renamed tonested-skillso no deleted skill is referenced in tests.gofmtclean,go build ./...andgo test ./...pass; grep confirms zero remainingai-docsreferences.🤖 Generated with Claude Code