Repository navigation
Running now: a phone's picked schedule shows over the session names pinned at the timeline's left - #291
Open
wangbinyq wants to merge 1 commit into
Conversation
…pinned at the timeline's left
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a phone, the schedule picked in Running now shows under the session names that the Coming up timeline pins at its left.
Why
The picked schedule's card is
.board-bar,z-index: 3. Each timeline lane's name is.rb-lane-name,position: sticky; left: 0; z-index: 4, so it stays at the timeline's left while the timeline pans. Both sit in the same stacking context, so 4 paints over 3: the name, with its opaque--cardbackground, cuts across the card..board-barnow takesz-index: 5: above the pinned names, below the timeline tip (.rb-tip,z-index: 50) and the app's overlays (45 and up).Before and after
390×560, real Chrome, a session with a
/schedulemessage, one pin tapped. The red boxes mark the lane names that paint over the card:Tested
test/running-board-stack.test.tsreadsweb/style.cssand asserts the bar outranks the pinned lane name, and the tip outranks the bar. It fails before the change (3 > 4is false) and passes after./schedulemessage, opened Running now, and tapped a pin. Withz-index: 3the script counted three lane names painting over the card; with5it counted none. The two screenshots above are that run.npm run check,npm run lint,npx prettier --check web/style.css test/running-board-stack.test.ts.npm test: five failures, indesign-lint-pages,design-render,design-verify, andwatch-tree. The same five fail onHEAD~1in this environment, and none of them readsweb/style.css.