Repository navigation
Conversation
…n thinking levels (add, remove, or send a level under another name); discovery reads them where the list says
…d its models say nothing of images or thinking
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAI-compatible endpoint form sets each model's ids only. Pi already reads
input,reasoning, andthinkingLevelMapfrommodels.json, but the form shows none of them, so an endpoint model gets no images ("image omitted") and no thinking levels unless I editmodels.jsonby hand.What changed
Each chosen model in the form has:
input: ["text", "image"].hard). Levels can be removed and added; Defaults puts back Low to Max. It writesreasoningandthinkingLevelMap(levels left out arenull).architecture.input_modalities/supported_parameters, and Ollama-stylecapabilities(vision,thinking).Fields the form does not manage stay as they are, as before. A model's levels come back on Edit as Pi reads them, also for an entry made by hand. Edit also opens when the server is older than the page and sends no images or thinking for its models.
Tests
npm run check,npm run lint.test/custom-providers.test.ts,test/providers.test.ts,test/model-providers.test.ts: 21 passed. New cases cover writing and reading backinput,reasoning, andthinkingLevelMap, renamed and removed levels, bad input, and discovery from both list styles.