refactor: extract shared help types into public glint/help module - #104
Draft
tylerbutler wants to merge 3 commits into
Draft
refactor: extract shared help types into public glint/help module#104tylerbutler wants to merge 3 commits into
tylerbutler wants to merge 3 commits into
Conversation
Add a default: Option(String) field to help.Flag and populate it from each flag's configured default via flag_default_info (with a join_csv helper for list flags). Foundation for rendering defaults in --help and for the public document tree.
Add the glint.show_flag_defaults builder and Config flag. When enabled, each flag with a configured default has (default: <value>) appended to its description in --help output. Disabled by default to preserve existing formatting.
Introduce glint/help with Metadata, Flag, and ArgsCount as the single source of truth; internal/help imports them instead of redeclaring. Extract a to_help_args helper and route the help/flag builders through the public types. Pure refactor: no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
glint/helpwithMetadata,Flag, andArgsCountas the single source of truth;internal/helpimports them instead of redeclaring.Extract a
to_help_argshelper and route thehelp/flagbuilders through the public types. Pure refactor: no behavior change.