Skip to content

feat: Observability for counting terminated PENDING execution timeouts #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuechao-qin wants to merge 1 commit into
base: ycq/feat-terminate-pending-container-after-timeout
Choose a base branch
from
+9 −0
Open

feat: Observability for counting terminated PENDING execution timeouts #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cloud_pipelines_backend/orchestrator_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,15 @@ def _terminate_timed_out_pending_execution(
# Mark the container execution as terminally failed
container_execution.ended_at = current_time
container_execution.status = bts.ContainerExecutionStatus.SYSTEM_ERROR
# TODO: Observe/Grafana queries for this metric:
# 1. sum(execution.system_errors{reason="pending_timeout"})
# → count of executions auto-terminated for exceeding the pending timeout
# 2. sum(execution.system_errors{reason=""}) or
# sum(execution.system_errors) - sum(execution.system_errors{reason="pending_timeout"})
# → count of all other system errors (exceptions, unhandled failures)
app_metrics.execution_system_errors.add(
1, attributes={"reason": "pending_timeout"}
)

# Record a human-readable error message (visible in the UI execution detail panel)
orchestration_error_message = (
Expand Down