Skip to content

Add editor v2 welcome spotlight and default path routing#2473

Open
Mbeaulne wants to merge 1 commit into
masterfrom
06-29-editor_and_component_search_v2_default
Open

Add editor v2 welcome spotlight and default path routing#2473
Mbeaulne wants to merge 1 commit into
masterfrom
06-29-editor_and_component_search_v2_default

Conversation

@Mbeaulne

@Mbeaulne Mbeaulne commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Introduces a getDefaultEditorPath helper in a new src/routes/editorRoutes.ts module that resolves the correct editor path based on whether the v2_editor feature flag is enabled. When the flag is on, navigation targets /editor-v2/<pipelineName>; otherwise it falls back to /editor/<pipelineName>. All hardcoded editor path constructions across the codebase have been replaced with this helper.

Additionally, the editorV2Route and editorV2PipelineRoute routes now include a beforeLoad guard that redirects users to the legacy editor (or pipelines dashboard) if the v2_editor flag is disabled, preventing direct access to the v2 editor without the flag.

A first-time welcome spotlight (EditorV2WelcomeSpotlight) has been added. When a user lands on the v2 editor for the first time, a spotlight overlay highlights the editor version toggle button with a brief explanatory card. Dismissal is persisted to local storage so the spotlight is only shown once.

The component_search feature flag default has been changed from false to true, enabling the experimental component search by default.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Enable the v2_editor feature flag and verify that all navigation entry points (pipeline row clicks, new pipeline button, import, run toolbar, favorites, recently viewed) route to /editor-v2/<name>.
  2. Disable the v2_editor flag and confirm all the same entry points route to /editor/<name> and that direct navigation to /editor-v2/<name> redirects appropriately.
  3. With the v2_editor flag enabled, open the v2 editor for the first time and confirm the welcome spotlight appears over the version toggle button, can be dismissed via the "Got it" button, Escape key, or clicking outside, and does not reappear after dismissal.
  4. Confirm the component search panel is now visible by default without manually enabling the flag.

Additional Comments

The getDefaultEditorPath utility centralises all editor URL construction, making future editor version routing changes a single-file update.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 06-29-editor_and_component_search_v2_default/321bedc

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Mbeaulne Mbeaulne changed the title Editor and component search v2 default Add editor v2 welcome spotlight and default path routing Jun 29, 2026
@Mbeaulne Mbeaulne marked this pull request as ready for review June 29, 2026 20:16
@Mbeaulne Mbeaulne requested a review from a team as a code owner June 29, 2026 20:16
@Mbeaulne Mbeaulne force-pushed the 06-29-editor_and_component_search_v2_default branch 3 times, most recently from a79b994 to 65b2b39 Compare June 30, 2026 13:16

@camielvs camielvs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. But I also feel it's a bit of a bandaid. We can also fix this by just making v2 editor the default and mounting it on the /editor basepath. The old legacy editor, if we want to keep it around for a bit longer, can go on a different path.

tl;dr let's move v2 editor out of beta and this PR is basically no longer needed.

@Mbeaulne Mbeaulne force-pushed the 06-29-editor_and_component_search_v2_default branch from 65b2b39 to 321bedc Compare July 8, 2026 12:37

Mbeaulne commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

I like the idea. But I also feel it's a bit of a bandaid. We can also fix this by just making v2 editor the default and mounting it on the /editor basepath. The old legacy editor, if we want to keep it around for a bit longer, can go on a different path.

tl;dr let's move v2 editor out of beta and this PR is basically no longer needed.

I agree that making Editor V2 the default and eventually mounting it at /editor is the right end state. I’d like to keep this PR
smaller though.

This PR is not meant to remove the beta flag or rename routes yet. It is just turning the existing V2 editor flag on by default,
so users get V2 by default while still having a way to switch back if they hit bugs, have workflow preferences, or need the
legacy editor for now.

Once we are fully ready to replace the legacy editor, we can do the larger cleanup: remove the beta flag, move V2 to /editor, and
decide what to do with the old editor route. For this PR, I think keeping the routes as they are and only changing the default
flag gives us a safer rollout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants