feat: harmonize the edit-save UX with the upgrade feature (legacy editor)#2383
Draft
morgan-wowk wants to merge 1 commit into
Draft
feat: harmonize the edit-save UX with the upgrade feature (legacy editor)#2383morgan-wowk wants to merge 1 commit into
morgan-wowk wants to merge 1 commit into
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Jun 5, 2026
Author
This was referenced Jun 5, 2026
…tor)
Aligns the "Edit Component" save flow with the existing component-upgrade /
replace flows so the two read as one family (the stack will be reviewed by the
upgrade authors). An edit is, in effect, an upgrade to a hand-edited version.
- Shared `ComponentEditSummary` (`src/components/shared/ComponentDiff/`):
renders the current → new digest transition (reusing `TrimmedDigest`) and the
breaking-change warning — the exact copy from the v2 `ReplaceConfirmationContent`
("Some inputs or outputs will be removed, and their connections will be
lost.") — above the shared `DiffSection`s. Used by both editors' save modals.
- `replaceTaskComponentRef` now seeds default arguments for newly added inputs,
matching the upgrade flow's `replaceTask` (it already pruned removed-input
args and orphaned downstream output bindings).
- The legacy choose-action modal shows the `ComponentEditSummary`
(digest transition + breaking warning) above the diff.
- Analytics: emit `pipeline_editor.component.edited` (sibling of `.upgraded` /
`.replaced`) on update/place with `componentMetadata(...)` + action.
Deliberate divergences from upgrade (kept on purpose): edit updates in place
(no task rename, unlike `replaceTaskNode`) and is undoable (so no
"This cannot be undone" copy).
Tests: new-input default seeding in `replaceTaskComponentRef`; `ComponentEditSummary`
warning/diff rendering.
morgan-wowk
force-pushed
the
mwowk/harmonize-edit-with-upgrade-v1
branch
from
a8115a8 to
e747268
Compare
morgan-wowk
force-pushed
the
mwowk/save-ux-place-as-new-task-v2
branch
from
b144787 to
a43b6a3
Compare
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments