fix: update deps and devtools theming - #245
Conversation
|
Important Review skippedToo many files! This PR contains 193 files, which is 43 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (193)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 69d49ca
☁️ Nx Cloud last updated this comment at |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
More templates
@tanstack/angular-pacer
@tanstack/pacer
@tanstack/pacer-devtools
@tanstack/pacer-lite
@tanstack/preact-pacer
@tanstack/preact-pacer-devtools
@tanstack/react-pacer
@tanstack/react-pacer-devtools
@tanstack/solid-pacer
@tanstack/solid-pacer-devtools
commit: |
There was a problem hiding this comment.
🔵 Human review recommended
It performs a broad dependency/toolchain upgrade across many packages (including framework major bumps) where correctness is hard to validate without running the full PR test suite.
Review details
- Files reviewed: 192/193 changed files
- Comments generated: 0 new
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
There was a problem hiding this comment.
🔵 Human review recommended
The PR performs broad dependency/tooling upgrades plus a devtools theming API migration, which needs a human-verified CI/test run to confirm compatibility.
Review details
- Files reviewed: 192/193 changed files
- Comments generated: 0 new
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
There was a problem hiding this comment.
🔵 Human review recommended
The PR touches a very large surface area of dependency/tooling upgrades across many packages/examples plus a devtools API migration, which is higher-risk without a full human verification pass.
Review details
- Files reviewed: 192/193 changed files
- Comments generated: 0 new
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
There was a problem hiding this comment.
🟡 Changes recommended
packages/pacer-devtools/tsdown.config.ts now relies on an implicit clean default for the first build entry while other entries explicitly set clean: false, making build behavior less deterministic across tsdown versions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
Suppressed comments (1)
packages/pacer-devtools/tsdown.config.ts:14
- The first tsdown build config in this array no longer specifies
clean, while the other entries explicitly setclean: false. Withtsdownalso being updated in this PR, relying on the tool’s default here can make build outputs inconsistent (and can change across tsdown versions). Consider settingclean: falseon this first entry too for consistency and deterministic behavior.
- Files reviewed: 202/203 changed files
- Comments generated: 0 new
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
There was a problem hiding this comment.
🟡 Changes recommended
Disabling tsdown cleaning across multiple published packages risks leaving stale dist artifacts between builds unless a clean step is guaranteed to run first.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
Suppressed comments (9)
packages/pacer/tsdown.config.ts:25
clean: falsemeanstsdownwill not clear the output directory, so removed/renamed entrypoints can leave stale files indistbetween builds. Since the package build script is justtsdown, this can result in outdated artifacts being published unless a separate clean step always runs first.
packages/react-pacer-devtools/tsdown.config.ts:11clean: falsemeanstsdownwill not clear the output directory, so removed/renamed entrypoints can leave stale files indistbetween builds. Since the package build script is justtsdown, this can result in outdated artifacts being published unless a separate clean step always runs first.
packages/pacer-lite/tsdown.config.ts:16clean: falsemeanstsdownwill not clear the output directory, so removed/renamed entrypoints can leave stale files indistbetween builds. Since the package build script is justtsdown, this can result in outdated artifacts being published unless a separate clean step always runs first.
packages/angular-pacer/tsdown.config.ts:25clean: falsemeanstsdownwill not clear the output directory, so removed/renamed entrypoints can leave stale files indistbetween builds. Since the package build script is justtsdown, this can result in outdated artifacts being published unless a separate clean step always runs first.
packages/react-pacer/tsdown.config.ts:27clean: falsemeanstsdownwill not clear the output directory, so removed/renamed entrypoints can leave stale files indistbetween builds. Since the package build script is justtsdown, this can result in outdated artifacts being published unless a separate clean step always runs first.
packages/solid-pacer/tsdown.config.ts:27clean: falsemeanstsdownwill not clear the output directory, so removed/renamed entrypoints can leave stale files indistbetween builds. Since the package build script is justtsdown, this can result in outdated artifacts being published unless a separate clean step always runs first.
packages/solid-pacer-devtools/tsdown.config.ts:11clean: falsemeanstsdownwill not clear the output directory, so removed/renamed entrypoints can leave stale files indistbetween builds. Since the package build script is justtsdown, this can result in outdated artifacts being published unless a separate clean step always runs first.
packages/preact-pacer/tsdown.config.ts:30clean: falsemeanstsdownwill not clear the output directory, so removed/renamed entrypoints can leave stale files indistbetween builds. Since the package build script is justtsdown, this can result in outdated artifacts being published unless a separate clean step always runs first.
packages/preact-pacer-devtools/tsdown.config.ts:13clean: falsemeanstsdownwill not clear the output directory, so removed/renamed entrypoints can leave stale files indistbetween builds. Since the package build script is justtsdown, this can result in outdated artifacts being published unless a separate clean step always runs first.
- Files reviewed: 202/203 changed files
- Comments generated: 0 new
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
There was a problem hiding this comment.
🟡 Changes recommended
pnpm-workspace.yaml uses version-qualified entries in trustPolicyExclude/minimumReleaseAgeExclude, which likely won’t match pnpm’s expected package-name (or glob) format and can break the intended install policy behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
Suppressed comments (2)
pnpm-workspace.yaml:40
minimumReleaseAgeExcludein pnpm expects package names/globs, notname@versionentries. As written, these exclusions likely won't match the actual packages being installed, so the minimum-release-age guard will still block updates.
pnpm-workspace.yaml:7trustPolicyExcludeexpects package names (or globs), not version-qualified specifiers.semver@6.3.1is likely treated as a literal package name and won't match installs ofsemver, so the exclusion won't apply (and may confuse future maintainers).
This issue also appears on line 36 of the same file.
- Files reviewed: 193/194 changed files
- Comments generated: 0 new
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
🎯 Changes
✅ Checklist
pnpm run test:pr.🚀 Release Impact