Skip to content

[TASK] Add test case for stringable component argument (#1379) #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s2b merged 1 commit into from
Jun 14, 2026
Merged

[TASK] Add test case for stringable component argument (#1379) #1382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/Functional/Core/Component/ComponentRenderingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Test;
use TYPO3Fluid\Fluid\Tests\Functional\AbstractFunctionalTestCase;
use TYPO3Fluid\Fluid\Tests\Functional\Fixtures\Various\UserWithToString;
use TYPO3Fluid\Fluid\View\TemplateView;

final class ComponentRenderingTest extends AbstractFunctionalTestCase
Expand All @@ -21,6 +22,7 @@ public static function basicComponentCollectionDataProvider(): iterable
return [
// parameters and escaping
'defined argument' => ['<my:testComponent title="TITLE" />', "\n\n\nMy test component TITLE\n"],
'defined argument, stringable input' => ['<my:testComponent title="{stringableObject}" />', "\n\n\nMy test component STRINGABLE\n"],
'defined argument with inline HTML escaped correctly' => ['<my:testComponent title="<b>TITLE</b>" />', "\n\n\nMy test component &lt;b&gt;TITLE&lt;/b&gt;\n"],
'defined argument with predefined HTML variable escaped correctly' => ['<my:testComponent title="{unsafeInput}" />', "\n\n\nMy test component &lt;script&gt;alert(&#039;This JavaScript should not be executed by the browser&#039;)&lt;/script&gt;\n"],
'defined argument with HTML variable escaped correctly' => ['<f:variable name="myHtml"><b>TITLE</b></f:variable><my:testComponent title="{myHtml}" />', "\n\n\nMy test component &lt;b&gt;TITLE&lt;/b&gt;\n"],
Expand Down Expand Up @@ -72,13 +74,15 @@ public function basicComponentCollection(string $source, string $expected): void
$view->getRenderingContext()->setCache(self::$cache);
$view->getRenderingContext()->getViewHelperResolver()->addNamespace('my', 'TYPO3Fluid\Fluid\Tests\Functional\Fixtures\ComponentCollections\BasicComponentCollection');
$view->getRenderingContext()->getVariableProvider()->add('unsafeInput', "<script>alert('This JavaScript should not be executed by the browser')</script>");
$view->getRenderingContext()->getVariableProvider()->add('stringableObject', new UserWithToString('STRINGABLE'));
$view->getRenderingContext()->getTemplatePaths()->setTemplateSource($source);
self::assertSame($expected, $view->render(), 'uncached');

$view = new TemplateView();
$view->getRenderingContext()->setCache(self::$cache);
$view->getRenderingContext()->getViewHelperResolver()->addNamespace('my', 'TYPO3Fluid\Fluid\Tests\Functional\Fixtures\ComponentCollections\BasicComponentCollection');
$view->getRenderingContext()->getVariableProvider()->add('unsafeInput', "<script>alert('This JavaScript should not be executed by the browser')</script>");
$view->getRenderingContext()->getVariableProvider()->add('stringableObject', new UserWithToString('STRINGABLE'));
$view->getRenderingContext()->getTemplatePaths()->setTemplateSource($source);
self::assertSame($expected, $view->render(), 'cached');
}
Expand Down
Loading