[TASK] Sanitize identifiers created client side - #122
Open
lolli42 wants to merge 1 commit into
Open
Conversation
Affects createFolderAction(), fileExistsAction(), fileUploadAction()
Collaborator
There was a problem hiding this comment.
– using identifier of existing file returns the expected file entity, as expected.
but
– using the same identifier with storage id changed to a non existent storage 2: the returned JSON is 200: {"state": 1}
– using the same identifier with changed foldername to a non-existing folder the returned JSON is 200: {"state": 1}
– using identifier of non existing file returns 200:{"state": 0}
Is that the expected behavior?
Contributor
Author
|
@juergen-venne yes. the api does not throw different error messages between 'no such storage' and 'no such folder'. there is no need to change this until it is really needed. |
juergen-venne
approved these changes
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affects createFolderAction(), fileExistsAction(), fileUploadAction()