Skip to content

[TASK] Sanitize identifiers created client side - #122

Open
lolli42 wants to merge 1 commit into
masterfrom
sanitizedFileExists
Open

[TASK] Sanitize identifiers created client side#122
lolli42 wants to merge 1 commit into
masterfrom
sanitizedFileExists

Conversation

@lolli42

@lolli42 lolli42 commented Apr 8, 2019

Copy link
Copy Markdown
Contributor

Affects createFolderAction(), fileExistsAction(), fileUploadAction()

Affects createFolderAction(), fileExistsAction(), fileUploadAction()

@juergen-venne juergen-venne left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

– using identifier of existing file returns the expected file entity, as expected.
but
– using the same identifier with storage id changed to a non existent storage 2: the returned JSON is 200: {"state": 1}
– using the same identifier with changed foldername to a non-existing folder the returned JSON is 200: {"state": 1}
– using identifier of non existing file returns 200:{"state": 0}
Is that the expected behavior?

@lolli42

lolli42 commented Apr 9, 2019

Copy link
Copy Markdown
Contributor Author

@juergen-venne yes. the api does not throw different error messages between 'no such storage' and 'no such folder'. there is no need to change this until it is really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants