[BUGFIX] Return file extension for processed files - #901
Open
tim-baecker wants to merge 4 commits into
Open
Conversation
ProcessedFile::getProperty('extension') always returns null because
processed-file records do not store an extension property. Use
getExtension() instead so image metadata (e.g. ogImage) exposes the
correct extension after processing.
Collaborator
|
@tim-baecker thx for the patch! Could fix the tests as well? |
Mock ProcessedFile::getExtension() and adjust the video baseline so unit tests match the FileUtility change that no longer reads extension via getProperty().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileUtilityreadsextensionviagetProperty('extension')on aProcessedFile.extensionproperty, so JSON always contains"extension": nullwhenever processing actually runs (maxWidth, crop, etc.).getExtension()instead (already used elsewhere inFileUtilityforimagefile_extchecks), which derives the extension from the filename of the served file.Example
With
processingConfiguration.maxWidth = 1200onogImage, properties previously looked like:and now correctly return:
Test plan
FilesProcessorwithmaxWidth/ crop enabledproperties.extensionmatches the processed file (e.g.jpg, orwebpwhenfileExtension = webp)