Skip to content

[BUGFIX] Do not modify external links, fixes for cropping, small optimization backported from 5.x branch - #892

Merged
twoldanski merged 2 commits into
4.xfrom
bugfix/891
Jul 21, 2026
Merged

[BUGFIX] Do not modify external links, fixes for cropping, small optimization backported from 5.x branch#892
twoldanski merged 2 commits into
4.xfrom
bugfix/891

Conversation

@twoldanski

Copy link
Copy Markdown
Collaborator

Resolves: #891

@twoldanski
twoldanski requested a review from lukaszuznanski May 21, 2026 09:17
@coveralls

coveralls commented May 21, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 26440568390

Warning

No base build found for commit fdf45e8 on 4.x.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 72.91%

Details

  • Patch coverage: 12 uncovered changes across 4 files (48 of 60 lines covered, 80.0%).

Uncovered Changes

File Changed Covered %
Classes/DataProcessing/ExtractPropertyProcessor.php 7 0 0.0%
Classes/DataProcessing/RootSiteProcessing/SiteProvider.php 2 0 0.0%
Classes/Utility/UrlUtility.php 17 15 88.24%
Classes/Event/Listener/AfterLinkIsGeneratedListener.php 4 3 75.0%
Total (11 files) 60 48 80.0%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 1591
Covered Lines: 1160
Line Coverage: 72.91%
Coverage Strength: 8.44 hits per line

💛 - Coveralls

Also resolve issue with cropping & autogenerate

Resolves: #830
@twoldanski twoldanski changed the title [BUGFIX] Do not modify external links [BUGFIX] Do not modify external links, fixes for cropping, small optimization backported from 5.x branch May 26, 2026
@twoldanski
twoldanski merged commit 0df0492 into 4.x Jul 21, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants