refactor(stage-profile): two-column editor layout (plan B)#68
Merged
Conversation
The tool had grown into eight stacked blocks with three visually
identical control rows mixing unrelated concerns. Restructured into
an editor layout - chart as the hero, controls grouped by intent:
- desktop (lg+): chart/stats/climb-table on the left, a sticky
340px sidebar on the right with three tabs - 圖面 (title, theme,
watermark/steepest toggles), 編輯 (reverse, trim, comparison,
waypoints - moved out of its own card), 輸出 (download, size,
transparency, preview/share/copy, share link). The island drops
its own max-w-3xl cap at lg (BaseLayout is already max-w-6xl)
- mobile keeps one column with the panel between stats and the
climbs table (flex order utilities; same DOM)
- source area (upload / guide / manual builder) collapses into a
one-line "⛰ {title} ・ 換一條路線" details bar once a profile
exists; full stack is unchanged for the empty state
- gradient-distribution chips moved from the download row to the
stats block where they belong
- no logic changes: all handlers, aria-labels and zh strings are
untouched; e2e updated only by inserting tab clicks (10 places),
all 12 stage-profile specs + full suite green; layout verified by
screenshot at 1440px and 390px
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool had grown into eight stacked blocks with three visually
identical control rows mixing unrelated concerns. Restructured into
an editor layout - chart as the hero, controls grouped by intent:
340px sidebar on the right with three tabs - 圖面 (title, theme,
watermark/steepest toggles), 編輯 (reverse, trim, comparison,
waypoints - moved out of its own card), 輸出 (download, size,
transparency, preview/share/copy, share link). The island drops
its own max-w-3xl cap at lg (BaseLayout is already max-w-6xl)
climbs table (flex order utilities; same DOM)
one-line "⛰ {title} ・ 換一條路線" details bar once a profile
exists; full stack is unchanged for the empty state
stats block where they belong
untouched; e2e updated only by inserting tab clicks (10 places),
all 12 stage-profile specs + full suite green; layout verified by
screenshot at 1440px and 390px
Co-Authored-By: Claude Fable 5 noreply@anthropic.com