ci: stop Coveralls upload failures from blocking the Rust job#152
Merged
Conversation
Every push-to-main CI run since #145 (and now PR runs) has failed at "Upload coverage to Coveralls" with a Coveralls-side internal server error, while build/clippy/tests all pass. A re-run reproduced the 500, so it is persistent, not transient. Two changes to the upload step: - Drop parallel: true. Parallel mode requires a closing parallel-finished webhook that this workflow never sent, so every build was left dangling open on Coveralls' side — the likely trigger for the persistent 500s. Parallel mode is also unnecessary: the Elixir job reports through excoveralls' own GitHub integration, so this is the workflow's only coverallsapp upload. - Add fail-on-error: false. Coverage upload is reporting, not a merge gate; a third-party outage should never block CI. Genuine coverage regressions are still visible on coveralls.io and in the PR comment.
|
Bito Automatic Review Skipped - Files Excluded |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every push-to-main CI run since #145 — and now PR #151's runs — failed at Upload coverage to Coveralls with
⚠️ Internal server error. Please contact Coveralls team., while build, clippy, and tests all pass. A re-run reproduced the 500, so it's persistent, not a one-off blip.What
Two changes to the Rust job's upload step:
parallel: true— parallel mode requires a closingparallel-finishedwebhook that this workflow never sent, so every build has been left dangling open on Coveralls' side (the likely trigger for the persistent 500s). It's also unnecessary: the Elixir job reports via excoveralls' own GitHub integration, making this the only coverallsapp upload in the workflow.fail-on-error: false— coverage upload is reporting, not a merge gate; a third-party outage should never block CI. Coverage regressions remain visible on coveralls.io and in PR comments.Verification
Once merged, re-running PR #151's checks will pick up the fixed workflow via the PR merge ref.