Skip to content

Fixes i18Find() on meteor 1.2#20

Open
phowat wants to merge 4 commits into
TAPevents:masterfrom
phowat:master
Open

Fixes i18Find() on meteor 1.2#20
phowat wants to merge 4 commits into
TAPevents:masterfrom
phowat:master

Conversation

@phowat

@phowat phowat commented Sep 22, 2015

Copy link
Copy Markdown

I experienced the same issue described in #19 after updating to Meteor 1.2 . Looking into the issue, I noticed it failed because conf.supported_languages was null. Since getLanguages() worked in the same context, I added that.

@phowat

phowat commented Sep 22, 2015

Copy link
Copy Markdown
Author

I'm sorry. I was unaware that if I pushed more commits into my fork's master branch they would show up here. But the same issue from i18nFind() was happening to isSupportedLanguage().

@vuongngo

Copy link
Copy Markdown

Thanks @phowat . It works :)

@pmoons

pmoons commented Jan 13, 2016

Copy link
Copy Markdown

Works! Thanks @phowat

@Szayet

Szayet commented Feb 6, 2016

Copy link
Copy Markdown

@phowat I saw you created a working Atmosphere fork till we are waiting. Could you please look at the #24 and it's solution and maybe include it in your fork? Thanks in advance!

@janat08

janat08 commented May 19, 2016

Copy link
Copy Markdown

Maybe get the author to add some1 as contributor as this is dead for almost a year.

@krishaamer

Copy link
Copy Markdown

Thanks @phowat !

@krishaamer

Copy link
Copy Markdown

Can this be merged please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants