Repository navigation
test(checkpoints): a keyryx statement with no signatures is refused - #484
Merged
Merged
Conversation
check_statement requires a non-empty `signatures` list before it reads a statement (the witness verifies the signatures, invariant 128), but no test served a statement without one, so a mutant that dropped the check survived the p256 0.14 PR's mutation run (#480). The keyryx stub gains two modes, no `signatures` and an empty list, and both must be refused as not of the known shape. One scenario, bound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkpoints::check_statementrequires a non-emptysignatureslist before it reads a keyryx statement (the witness verifies the signatures, invariant 128), but no test served a statement without one: a mutant that dropped the check survived the mutation run of #480.crates/gateway/src/checkpoints/tests.rsgains two modes, nosignaturesand an empty list.a_statement_with_no_signatures_is_refusedrequires both to be refused as not of the known shape.features/signed-checkpoints-of-the-event-stream.feature, bound to the test.Red first: the throwaway draft #483 runs this test with the presence check disabled and requires it to fail. No product code changes here.
🤖 Generated with Claude Code