Skip to content

security: replace Math.random with crypto.randomBytes for PKCE #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AidanDalyAus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

security: replace Math.random with crypto.randomBytes for PKCE #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,7 +1124,8 @@ class VwWeconnect extends utils.Adapter {
};
const qmAuth = this.getQmauth();
this.log.debug(qmAuth);
this.log.debug(JSON.stringify(body));
// Security fix: don't log auth code and code_verifier (CWE-532)
this.log.debug("Token request prepared (body redacted)");

request(
{
Expand Down Expand Up @@ -5724,9 +5725,8 @@ class VwWeconnect extends utils.Adapter {
});
}
getCodeChallenge() {
const chars = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
let result = "";
for (let i = 64; i > 0; --i) result += chars[Math.floor(Math.random() * chars.length)];
// Security fix: use crypto.randomBytes instead of Math.random (CWE-330)
let result = crypto.randomBytes(48).toString("base64url").slice(0, 64);
result = Buffer.from(result).toString("base64");
result = result.replace(/\+/g, "-").replace(/\//g, "_").replace(/=/g, "");
let hash = crypto.createHash("sha256").update(result).digest("base64");
Expand All @@ -5735,17 +5735,17 @@ class VwWeconnect extends utils.Adapter {
return [result, hash];
}
getCodeChallengev2() {
const chars = "0123456789abcdef";
let result = "";
for (let i = 64; i > 0; --i) result += chars[Math.floor(Math.random() * chars.length)];
// Security fix: use crypto.randomBytes instead of Math.random (CWE-330)
let result = crypto.randomBytes(32).toString("hex");
let hash = crypto.createHash("sha256").update(result).digest("base64");
hash = hash.replace(/\+/g, "-").replace(/\//g, "_").replace(/=/g, "");

return [result, hash];
}
getNonce() {
const timestamp = Date.now();
let hash = crypto.createHash("sha256").update(timestamp.toString()).digest("base64");
// Security fix: use random bytes instead of deterministic timestamp
const randomData = crypto.randomBytes(32).toString("hex");
let hash = crypto.createHash("sha256").update(randomData).digest("base64");
hash = hash.slice(0, hash.length - 1);
return hash;
}
Expand Down