perf: move Community batch writes onto dense native rows - #9
Closed
wolfiesch wants to merge 5 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the common Community
append()/write_rows()batch path from per-cell nestedBTreeMapinsertion to compact native dense rows while retaining sparse last-write-wins overlays for later edits and formats.The stale portion of the audit is corrected here: current Community already crosses PyO3 once per append/bulk buffer. This PR therefore claims removal of the native per-cell tree storage, not removal of per-cell FFI.
Implementation
Production-profile evidence
Evidence workflow: https://github.com/SynthGL/wolfxl-community/actions/runs/33599139211
Artifact: https://github.com/SynthGL/wolfxl-community/actions/runs/33599139211/artifacts/9834572130
Method:
cc624eabd6f65301ccc5d9adb24a6cb6b0d271d55c6a31b888bdefd50c981703e9ab4fbe3626912bPublic Python API
The supported claim is therefore 1.31–1.51× faster save/flush and 1.20–1.46× faster end-to-end on the measured Community append/bulk lanes—not the audit's unmeasured 1.5–3× range.
Direct Rust phase and allocations
Sparse vs dense native storage plus
sheetDataemission, 400,000 numeric cells:Peak RSS
600,000 unique-string cells, three isolated samples per side:
Correctness and validation
The temporary benchmark workflow was removed after publishing the evidence artifact.