Skip to content

fix(results): tag unsupported failure explanations - #37

Merged
wolfiesch merged 1 commit into
masterfrom
codex/postmerge-failure-explanation-tag
May 8, 2026
Merged

fix(results): tag unsupported failure explanations#37
wolfiesch merged 1 commit into
masterfrom
codex/postmerge-failure-explanation-tag

Conversation

@wolfiesch

Copy link
Copy Markdown
Collaborator

Summary

Verification

  • uv run mypy src/excelbench/results/failure_explainer.py
  • uv run pytest tests/test_failure_explainer.py tests/test_results_html_dashboard.py tests/test_dashboard.py
  • uv run excelbench benchmark --tests fixtures/excel --output /tmp/excelbench-results-postmerge-fix

Copilot AI review requested due to automatic review settings May 8, 2026 20:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures FailureExplanation objects created for UNSUPPORTED_FEATURE diagnostics include the tag field, preventing type-check/rendering errors and correctly labeling unsupported outcomes in report/dashboard layers.

Changes:

  • Add tag="unsupported" when constructing FailureExplanation for DiagnosticCategory.UNSUPPORTED_FEATURE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wolfiesch
wolfiesch merged commit 9a0b300 into master May 8, 2026
9 checks passed
@wolfiesch
wolfiesch deleted the codex/postmerge-failure-explanation-tag branch May 8, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants