fix(deps): bump lxml 6.0.2 → 6.1.0 (closes dependabot #8 / XXE high-sev) - #29
Closed
wolfiesch wants to merge 1 commit into
Closed
fix(deps): bump lxml 6.0.2 → 6.1.0 (closes dependabot #8 / XXE high-sev)#29wolfiesch wants to merge 1 commit into
wolfiesch wants to merge 1 commit into
Conversation
Patches a high-severity XXE vulnerability in lxml's iterparse() and ETCompatXMLParser() default configuration that allowed reading local files via crafted XML. lxml is a transitive dep via appscript (used by xlwings on macOS/Linux); ExcelBench does not use it directly, but it ships in our resolved environment. Lockfile-only change. uv lock --upgrade-package lxml. Verified: uv run pytest tests/ → 1140 passed, 32 skipped, 6 xfailed Closes dependabot alert #8. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes dependabot alert #8.
lxml < 6.1.0ships with defaultiterparse()andETCompatXMLParser()configurations that resolve external XML entities, allowing crafted XML documents to read local files (XXE). Patched inlxml 6.1.0. Severity: high.lxmlis a transitive dependency viaappscript(used byxlwingson macOS/Linux). ExcelBench does not importlxmldirectly, but it lands in our resolved environment, which is why dependabot flagged it onmaster.Change
Lockfile-only.
uv lock --upgrade-package lxmlbumps6.0.2 → 6.1.0. Nopyproject.tomlchange needed because the upper bound was already permissive.Test plan
uv lock --upgrade-package lxml→lxml 6.0.2 → 6.1.0uv sync --extra dev --extra rustcleanuv run pytest tests/→ 1140 passed, 32 skipped, 6 xfailed (no regressions)masterafter merge to confirm feat(perf): throughput dashboard + xlsxwriter fixture compat #8 closesIndependent of PR #28 (S1 perf-mem-honesty); both touch different surfaces and can land in either order.
🤖 Generated with Claude Code