Skip to content

Fixed image generation, changed license to gnu agplv3 and added ligth tallystate#15

Merged
IJIJI merged 9 commits into
mainfrom
dev
May 25, 2026
Merged

Fixed image generation, changed license to gnu agplv3 and added ligth tallystate#15
IJIJI merged 9 commits into
mainfrom
dev

Conversation

@IJIJI

@IJIJI IJIJI commented May 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 25, 2026 20:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Beacon device firmware configuration and behavior by adding an explicit ESP-IDF target per satellite, introducing a new TallyState::LIGHT (white) across the firmware, and switching the repository license text to GNU AGPLv3.

Changes:

  • Add CONFIG_IDF_TARGET to multiple satellite sdkconfig.defaults files and enable a USB JTAG secondary console for the HD-WF2 target.
  • Introduce TallyState::LIGHT and wire it through color mapping, display state naming, and MQTT tally parsing; adjust the default disconnect state to WARNING.
  • Update the release workflow’s merge-bin output name/location and replace the LICENSE text with AGPLv3.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
satelites/Synapt/Satelite-Pro/sdkconfig.defaults Adds explicit ESP-IDF target (esp32s2) for build matrix discovery.
satelites/Huidu/HD-WF2/sdkconfig.defaults Adds explicit ESP-IDF target (esp32s3) and enables secondary USB Serial JTAG console.
satelites/CYD/CYD-Satelite/sdkconfig.defaults Adds explicit ESP-IDF target (esp32).
README.md Adds TODO entry to implement the new LIGHT state.
LICENSE Switches license text to GNU AGPLv3.
components/beacon_device/types/TallyTypes.hpp Adds TallyState::LIGHT.
components/beacon_device/orchestrator/handlers/colorPatternMap/DefaultColorAlertPatternMap.cpp Adds a TODO note related to extending color usage.
components/beacon_device/mapper/FixedTallyColorMapper.hpp Maps LIGHT to white and reorders state-to-color cases.
components/beacon_device/consumer/IDisplayConsumer.hpp Adds LIGHT to state name mapping for display/debug text.
components/beacon_device/config/Settings.hpp Changes default state_on_disconnect from INFO to WARNING.
components/beacon_device/beaconConnection/TcpMqttBeaconConnection.hpp Adds MQTT parsing support for "LIGHT" tally state.
.github/workflows/release.yml Changes merge-bin output path/name used in the release build workflow.
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:70

  • idf.py merge-bin -o merged.bin now outputs merged.bin in the project directory, but the packaging step still copies ${{ matrix.path }}/build/merged.bin. This will fail the workflow (file not found) unless the output path or the copy path is updated to match.
          command: idf.py build && idf.py merge-bin -o merged.bin

      - name: Package firmware
        run: |
          VERSION="${{ github.event.release.tag_name || env.TARGET_BRANCH }}"
          NAME="${{ matrix.name }}-${VERSION}"
          cp "${{ matrix.path }}/build/merged.bin" "$GITHUB_WORKSPACE/${NAME}.bin"


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread satelites/Huidu/HD-WF2/sdkconfig.defaults Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 25, 2026 20:38
@IJIJI
IJIJI merged commit d1b8330 into main May 25, 2026
1 check failed
@IJIJI
IJIJI removed the request for review from Copilot May 25, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants