Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Beacon device firmware configuration and behavior by adding an explicit ESP-IDF target per satellite, introducing a new TallyState::LIGHT (white) across the firmware, and switching the repository license text to GNU AGPLv3.
Changes:
- Add
CONFIG_IDF_TARGETto multiple satellitesdkconfig.defaultsfiles and enable a USB JTAG secondary console for the HD-WF2 target. - Introduce
TallyState::LIGHTand wire it through color mapping, display state naming, and MQTT tally parsing; adjust the default disconnect state toWARNING. - Update the release workflow’s merge-bin output name/location and replace the LICENSE text with AGPLv3.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
satelites/Synapt/Satelite-Pro/sdkconfig.defaults |
Adds explicit ESP-IDF target (esp32s2) for build matrix discovery. |
satelites/Huidu/HD-WF2/sdkconfig.defaults |
Adds explicit ESP-IDF target (esp32s3) and enables secondary USB Serial JTAG console. |
satelites/CYD/CYD-Satelite/sdkconfig.defaults |
Adds explicit ESP-IDF target (esp32). |
README.md |
Adds TODO entry to implement the new LIGHT state. |
LICENSE |
Switches license text to GNU AGPLv3. |
components/beacon_device/types/TallyTypes.hpp |
Adds TallyState::LIGHT. |
components/beacon_device/orchestrator/handlers/colorPatternMap/DefaultColorAlertPatternMap.cpp |
Adds a TODO note related to extending color usage. |
components/beacon_device/mapper/FixedTallyColorMapper.hpp |
Maps LIGHT to white and reorders state-to-color cases. |
components/beacon_device/consumer/IDisplayConsumer.hpp |
Adds LIGHT to state name mapping for display/debug text. |
components/beacon_device/config/Settings.hpp |
Changes default state_on_disconnect from INFO to WARNING. |
components/beacon_device/beaconConnection/TcpMqttBeaconConnection.hpp |
Adds MQTT parsing support for "LIGHT" tally state. |
.github/workflows/release.yml |
Changes merge-bin output path/name used in the release build workflow. |
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:70
idf.py merge-bin -o merged.binnow outputsmerged.binin the project directory, but the packaging step still copies${{ matrix.path }}/build/merged.bin. This will fail the workflow (file not found) unless the output path or the copy path is updated to match.
command: idf.py build && idf.py merge-bin -o merged.bin
- name: Package firmware
run: |
VERSION="${{ github.event.release.tag_name || env.TARGET_BRANCH }}"
NAME="${{ matrix.name }}-${VERSION}"
cp "${{ matrix.path }}/build/merged.bin" "$GITHUB_WORKSPACE/${NAME}.bin"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.