Conversation
…d update artifact naming
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project documentation with a new “Hardware TODO” section and adjusts the GitHub Actions release workflow to build and publish a single merged firmware binary per discovered device under satelites/.
Changes:
- Added WIP hardware descriptions to
README.mdunder a new “Hardware TODO” section. - Updated
release.ymlto (a) discover device projects by scanningsatelites/*/*/CMakeLists.txt, (b) build +idf.py merge-bin, and (c) upload.binfirmware artifacts (withfail-fast: false).
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Adds new hardware WIP/TODO documentation entries (currently includes placeholder/broken links). |
| .github/workflows/release.yml | Changes release pipeline to discover devices dynamically and publish merged .bin firmware artifacts. |
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:69
- The artifact/release filename uses
VERSIONderived fromenv.TARGET_BRANCH(viagithub.ref_name). Branch names can legally contain/(e.g.,feature/foo), which would produce an invalid path like...-feature/foo.binand cause thecp/upload steps to fail. Consider sanitizingVERSION(e.g., replace/with-) before buildingNAMEfor filenames.
VERSION="${{ github.event.release.tag_name || env.TARGET_BRANCH }}"
NAME="${{ matrix.name }}-${VERSION}"
cp "${{ matrix.path }}/build/merged.bin" "$GITHUB_WORKSPACE/${NAME}.bin"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.