Repository navigation
Test: Add missing test coverage for access-lease and subscription - #141
Merged
Merged
Conversation
|
@Izebby Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Busiii-adetiba
pushed a commit
that referenced
this pull request
Oct 17, 2026
) The init front-running fix for access-lease (#43, review item 11) was recorded as SV-12 "Resolved", but the admin.require_auth() check and its test were dropped when PR #141 was merged, and subscription and vault-registry never had it. Mark SV-12 as open/regressed across all three contracts, correct the status line and access-control matrix, and add the init front-running residual risk with operational mitigations until the check is restored. Closes #104 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses missing test coverage across the access-lease and subscription contracts:
set_admintests: Added tests to bothaccess-leaseandsubscriptionverifying thatset_adminproperly rejects unauthorized callers.upgradetests: Added tests validatingupgradesuccess, rejection by non-admins, and failure before initialization.events_have_documented_shapein the subscription contract to validate the payload structure of all event types (setadmin,plan,subscribe,renew,cancel,setactive).Closes #60
Closes #57
Closes #58
Closes #56