Skip to content

Updated height maths and documentation#44

Merged
techisdead merged 6 commits into
mainfrom
issue40
Apr 8, 2026
Merged

Updated height maths and documentation#44
techisdead merged 6 commits into
mainfrom
issue40

Conversation

@pyandell99

Copy link
Copy Markdown
Collaborator
  • Changed 2*mean_height to eff_detection_height in obs_flux.
  • Added notes to a few places about using the max rsh as the effective detection height and desktop truncating the observations.
  • Updated the vignettes to reflect this

@pyandell99 pyandell99 linked an issue Mar 20, 2026 that may be closed by this pull request
@LucindaRoberts

LucindaRoberts commented Mar 30, 2026

Copy link
Copy Markdown

I have made some vignette changes here

Stochastic:
~/DEV_Symbolix/CRMC_CollisionRiskModelCollection/collision/LR_effectiveHeightCalcs/simple-simulation-example.Rmd

Deterministic:
~/DEV_Symbolix/CRMC_CollisionRiskModelCollection/collision/LR_effectiveHeightCalcs/deterministic-example.Rmd

Notes on changes on card : https://app.shortcut.com/symbolix/story/66050/sym-crmd-side-by-side-comparison-of-twte-model-modified-in-sprint

@techisdead
techisdead self-requested a review April 8, 2026 04:52
@techisdead

Copy link
Copy Markdown
Contributor

Have reviewed. Vignettes updated including some additional edits by me and @LucindaRoberts. Checks pass, tests pass, docs re-doc-ed. I've updated new and bumped this to a 1.1.9000 dev version because we have a couple of other updates to make then we can bump the release

@techisdead
techisdead merged commit 8dc1cc1 into main Apr 8, 2026
1 check passed
@techisdead
techisdead deleted the issue40 branch April 8, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Effective detection height

3 participants