Skip to content

Fix pixel glitch on hover for Mauritius and Retro themes - #4670

Closed
Drishtyaggarwal wants to merge 6 commits into
Syknapse:masterfrom
Drishtyaggarwal:add-drishty-card
Closed

Fix pixel glitch on hover for Mauritius and Retro themes#4670
Drishtyaggarwal wants to merge 6 commits into
Syknapse:masterfrom
Drishtyaggarwal:add-drishty-card

Conversation

@Drishtyaggarwal

Copy link
Copy Markdown
Contributor

📝 Making another type of change?

What does this PR change?

Fixes a pixel glitch that appeared on hover for Mauritius and Retro theme cards, caused by a margin gap exposing the card's background color.

Why?

Resolves #4667

Type of change

  • Bug fix

Checklist

  • I've linked the relevant issue above
  • My changes only touch the files relevant to this PR
  • I've tested locally where applicable

@github-actions github-actions Bot added card-submission New contributor card submission enhancement New feature or enhancement labels Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @Drishtyaggarwal! 👋

This PR changes files outside the cards/ directory:

  • assets/style.css
  • assets/themes.css

Please submit a PR that only adds your card at cards/your-github-username.html. Any other changes need a separate PR with a linked issue first.

@Drishtyaggarwal

Copy link
Copy Markdown
Contributor Author

"This PR is linked to issue #4667 which I was assigned to. The changes to assets/style.css and assets/themes.css are the actual bug fix."

@kuramaSeige-OFC kuramaSeige-OFC left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theme Mauritius it's still have the glitch, In Retro it's gone

Can you fix the Mauritius's Glitch as well if possible

Comment thread cards/Drishtyaggarwal.html Outdated
@kuramaSeige-OFC kuramaSeige-OFC added the changes requested Contributor is requested to make the required changes label Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @Drishtyaggarwal! 👋

This PR changes files outside the cards/ directory:

  • assets/style.css
  • assets/themes.css

Please submit a PR that only adds your card at cards/your-github-username.html. Any other changes need a separate PR with a linked issue first.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @Drishtyaggarwal! 👋

This PR changes files outside the cards/ directory:

  • assets/style.css
  • assets/themes.css

Please submit a PR that only adds your card at cards/your-github-username.html. Any other changes need a separate PR with a linked issue first.

@Drishtyaggarwal

Copy link
Copy Markdown
Contributor Author

Fixed the ampersand encoding issue and the Mauritius theme glitch in the Fetched From section. Ready for re-review!

Comment thread assets/style.css Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Hi @Drishtyaggarwal! 👋

This PR changes files outside the cards/ directory:

  • assets/style.css
  • assets/themes.css

Please submit a PR that only adds your card at cards/your-github-username.html. Any other changes need a separate PR with a linked issue first.

@Drishtyaggarwal

Copy link
Copy Markdown
Contributor Author

Hi! I solved the glitch without deleting the original code and avoiding !important. Hope it's better. Please give your feedback after reviewing, and if there's any problem, feel free to ask me to resolve it.

@github-actions

Copy link
Copy Markdown
Contributor

This PR has had no activity for 21 days. Please push a fix to address the requested changes — otherwise it will be closed in 21 days. The bot comment on your PR explains exactly what needs fixing.

@github-actions github-actions Bot added the Stale label Jul 13, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This PR was closed due to 42 days of inactivity after changes were requested. Feel free to open a new PR once the issues are resolved.

@github-actions github-actions Bot closed this Aug 3, 2026
@kuramaSeige-OFC

Copy link
Copy Markdown
Collaborator

Hi @Drishtyaggarwal,

Really sorry for the late review,

Currently that issue is gone but there is another issue raised in your PR

image

The fetched from file name is not visible in Retro theme

I guess it's cause of you've removed some css properties and changed theme colors

check the card template and confirm which theme variable supplies the color and restore it.

Regards,
@kuramaSeige-OFC

@github-actions

Copy link
Copy Markdown
Contributor

Hi @Drishtyaggarwal! 👋

This PR changes files outside the cards/ directory:

  • assets/style.css
  • assets/themes.css

Please submit a PR that only adds your card at cards/your-github-username.html. Any other changes need a separate PR with a linked issue first.

@github-actions github-actions Bot removed the Stale label Aug 22, 2026
@Drishtyaggarwal

Copy link
Copy Markdown
Contributor Author

its okay, ill review it know

@github-actions

Copy link
Copy Markdown
Contributor

Hi @Drishtyaggarwal! 👋

This PR changes files outside the cards/ directory:

  • assets/style.css
  • assets/themes.css

Please submit a PR that only adds your card at cards/your-github-username.html. Any other changes need a separate PR with a linked issue first.

@Drishtyaggarwal

Copy link
Copy Markdown
Contributor Author

Hi @kuramaSeige-OFC, thanks for pointing this out! 🙌

You were right — it was a CSS variable issue. In the Retro theme, the fetched-from filename link was using --color-primary (
#3a6ea5), which is the same color as the card background, so it was invisible. I've added an explicit color: #fff override for .card p small a in the Retro theme (similar to how it's already handled in the Classic theme), and pushed the fix — it's now part of this PR.

Please let me know if you'd like any changes!

@github-actions

Copy link
Copy Markdown
Contributor

Hi @Drishtyaggarwal! 👋

This PR changes files outside the cards/ directory:

  • assets/style.css
  • assets/themes.css

Please submit a PR that only adds your card at cards/your-github-username.html. Any other changes need a separate PR with a linked issue first.

@Drishtyaggarwal

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #4739, which cleanly adds just the card file (cards/) as required. I'll open separate issues + PRs for the CSS/theme fixes that were previously bundled here (Mauritius hover glitch, Retro theme fetched-from filename visibility, ampersand fix).

@kuramaSeige-OFC

Copy link
Copy Markdown
Collaborator

Yeah sure @Drishtyaggarwal, create a seperate PR and cite it with the same issue #4667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

card-submission New contributor card submission changes requested Contributor is requested to make the required changes enhancement New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Pixel Glitch in some theme cards

2 participants