Fix pixel glitch on hover for Mauritius and Retro themes - #4670
Fix pixel glitch on hover for Mauritius and Retro themes#4670Drishtyaggarwal wants to merge 6 commits into
Conversation
|
Hi @Drishtyaggarwal! 👋 This PR changes files outside the
Please submit a PR that only adds your card at |
|
"This PR is linked to issue #4667 which I was assigned to. The changes to assets/style.css and assets/themes.css are the actual bug fix." |
kuramaSeige-OFC
left a comment
There was a problem hiding this comment.
In theme Mauritius it's still have the glitch, In Retro it's gone
Can you fix the Mauritius's Glitch as well if possible
|
Hi @Drishtyaggarwal! 👋 This PR changes files outside the
Please submit a PR that only adds your card at |
|
Hi @Drishtyaggarwal! 👋 This PR changes files outside the
Please submit a PR that only adds your card at |
|
Fixed the ampersand encoding issue and the Mauritius theme glitch in the Fetched From section. Ready for re-review! |
|
Hi @Drishtyaggarwal! 👋 This PR changes files outside the
Please submit a PR that only adds your card at |
|
Hi! I solved the glitch without deleting the original code and avoiding !important. Hope it's better. Please give your feedback after reviewing, and if there's any problem, feel free to ask me to resolve it. |
|
This PR has had no activity for 21 days. Please push a fix to address the requested changes — otherwise it will be closed in 21 days. The bot comment on your PR explains exactly what needs fixing. |
|
This PR was closed due to 42 days of inactivity after changes were requested. Feel free to open a new PR once the issues are resolved. |
|
Hi @Drishtyaggarwal, Really sorry for the late review, Currently that issue is gone but there is another issue raised in your PR
The I guess it's cause of you've removed some css properties and changed theme colors check the card template and confirm which theme variable supplies the color and restore it. Regards, |
|
Hi @Drishtyaggarwal! 👋 This PR changes files outside the
Please submit a PR that only adds your card at |
|
its okay, ill review it know |
|
Hi @Drishtyaggarwal! 👋 This PR changes files outside the
Please submit a PR that only adds your card at |
|
Hi @kuramaSeige-OFC, thanks for pointing this out! 🙌 You were right — it was a CSS variable issue. In the Retro theme, the fetched-from filename link was using --color-primary ( Please let me know if you'd like any changes! |
|
Hi @Drishtyaggarwal! 👋 This PR changes files outside the
Please submit a PR that only adds your card at |
|
Closing this in favor of #4739, which cleanly adds just the card file (cards/) as required. I'll open separate issues + PRs for the CSS/theme fixes that were previously bundled here (Mauritius hover glitch, Retro theme fetched-from filename visibility, ampersand fix). |
|
Yeah sure @Drishtyaggarwal, create a seperate PR and cite it with the same issue #4667 |

📝 Making another type of change?
What does this PR change?
Fixes a pixel glitch that appeared on hover for Mauritius and Retro theme cards, caused by a margin gap exposing the card's background color.
Why?
Resolves #4667
Type of change
Checklist