fix(setup): abort rejected silent preflight - #73
Merged
Conversation
Run the bounded signer inspection during wizard initialization and use Inno's silent abort path on rejection. This prevents PrepareToInstall error UI from keeping a very-silent Setup process alive.
Expose the bounded preflight to InitializeWizard in Pascal declaration order. The pinned Inno Setup 7.0.2 compiler now validates the complete installer script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InitializeWizardVerification
uv run --locked python -m pytest tests/test_build_profiles.py -q(11 passed)git diff --checkImmediate blocker
Release run 31741812265 proved the helpers are first in the archive but an untrusted signer still left Setup alive at
SETUP-NOT-STARTED. The remaining wait is Inno's PrepareToInstall error UI path.AbortfromInitializeWizardis the documented silent termination path.